Add: check_encoding -> print line with found char

greenbone · Feb 28, 2025 · 4e3374e · 4e3374e
1 parent 948ff2b
commit 4e3374e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/tests/plugins/test_encoding.py b/tests/plugins/test_encoding.py
@@ -70,11 +70,11 @@ def test_some_invalid_characters(self):
                 results[0].message,
             )
             self.assertEqual(
-                "Found invalid character",
+                "Found invalid character in line: 1",
                 results[1].message,
             )
             self.assertEqual(
-                "Found invalid character",
+                "Found invalid character in line: 2",
                 results[2].message,
             )
 

diff --git a/troubadix/plugins/encoding.py b/troubadix/plugins/encoding.py
@@ -26,7 +26,7 @@
 # Only the ASCII and extended ASCII for now... # https://www.ascii-code.com/
 # CHAR_SET = r"[^\x00-\xFF]"
 # Temporary only check for chars in between 7f-9f, like in the old Feed-QA...
-CHAR_SET = r"[\x7F-\x9F]"
+INVALID_CHAR_PATTERN = re.compile(r"[\x7F-\x9F]")
 
 ALLOWED_ENCODINGS = ["ascii", "latin_1"]
 
@@ -52,10 +52,10 @@ def check_lines(
             )
 
         for index, line in enumerate(lines, 1):
-            encoding = re.search(CHAR_SET, line)
-            if encoding is not None:
+            encoding = INVALID_CHAR_PATTERN.search(line)
+            if encoding:
                 yield LinterError(
-                    "Found invalid character",
+                    f"Found invalid character in line: {index}",
                     file=nasl_file,
                     plugin=self.name,
                     line=index,