Change: script_calls_recommended group2 regex to match multilne

greenbone · Sep 10, 2024 · 63b5a34 · 63b5a34
1 parent 4bb1ac3
commit 63b5a34
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/tests/plugins/test_script_calls_recommended.py b/tests/plugins/test_script_calls_recommended.py
@@ -67,11 +67,10 @@ def test_missing_calls(self):
 
     def test_dependencies_multiline(self):
         content = (
+            # tests group1
             '  script_dependencies("123",\n"456");\n'
-            "  script_require_ports();\n"
-            "  script_require_udp_ports();\n"
-            "  script_require_keys();\n"
-            "  script_mandatory_keys();\n"
+            # tests group2
+            '  script_mandatory_keys("foo",\n"bar");\n'
         )
         fake_context = self.create_file_plugin_context(
             nasl_file=self.path, file_content=content

diff --git a/troubadix/plugins/script_calls_recommended.py b/troubadix/plugins/script_calls_recommended.py
@@ -73,7 +73,9 @@ def check_content(
         ]
 
         if not _get_special_script_tag_pattern(
-            name=rf"({'|'.join(recommended_many_call)})", value=".*"
+            name=rf"({'|'.join(recommended_many_call)})",
+            value=".*?",
+            flags=re.DOTALL,
         ).search(file_content):
             yield LinterWarning(
                 "VT contains none of the following recommended calls: "