Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Codecov in workflow #683

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix: Codecov in workflow #683

merged 1 commit into from
Mar 21, 2024

Conversation

n-thumann
Copy link
Member

@n-thumann n-thumann commented Mar 21, 2024

What

This PR fixes Codecov in our workflow.

Why

To have Codecov working again.
For whatever reason we already have secrets.CODECOV_TOKEN present, but we're not using it.

References

This kind of error has been first introduced in #668, but can't really tell why. Also, the error got shadowed by another one, because in the CI runs prior to that one it also failed due to a different error.

Checklist

  • Tests

@n-thumann n-thumann requested a review from a team as a code owner March 21, 2024 15:19
@n-thumann n-thumann marked this pull request as draft March 21, 2024 15:19
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (fbc2352) to head (ddbed66).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   78.19%   78.76%   +0.56%     
==========================================
  Files          80       81       +1     
  Lines        2692     2736      +44     
  Branches      569      577       +8     
==========================================
+ Hits         2105     2155      +50     
+ Misses        441      440       -1     
+ Partials      146      141       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-thumann n-thumann marked this pull request as ready for review March 21, 2024 15:23
@n-thumann n-thumann enabled auto-merge March 21, 2024 15:25
@cfi-gb
Copy link
Member

cfi-gb commented Mar 21, 2024

Only a remark: Do we need a conventional commit for this change? Asking because with this it will end up as a changelog entry for Troubadix on the next release here:

https://github.com/greenbone/troubadix/releases

while this is completely not about Troubadix but just some internal repo maintenance.

@n-thumann n-thumann merged commit 263d4ac into main Mar 21, 2024
13 checks passed
@n-thumann n-thumann deleted the fix_codecov branch March 21, 2024 15:33
@n-thumann
Copy link
Member Author

Only a remark: Do we need a conventional commit for this change? Asking because with this it will end up as a changelog entry for Troubadix on the next release here:

AFAIK from other projects it's not uncommon to have also changes that are not directly related the actual code in the changelog 🤔 I'd don't mind keeping it there, but I leave that up to discussion

@cfi-gb
Copy link
Member

cfi-gb commented Mar 21, 2024

IMHO any changes not directly related to the software shipped with a repository shouldn't end up in the changelog of that repository. This is something i personally really dislike in these other projects:

As a user of the software i have no interest in anything other then actual changes to the software, a changelog should purely contain only changes to the software itself and shouldn't include anything development related like e.g. "Codecov" as i simply not using that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants