Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Ignore script_xref() tags in overlong decription lines plugin. #684

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Mar 21, 2024

What

This is a short follow-up to #681 so that script_xref() tags are also ignored as these could also contain overlong URLs which can exceed the 100 chars limit.

Why

Avoid reporting non-changeable stuff/things

References

Related to: VTOPS-174

Checklist

  • Tests

@cfi-gb cfi-gb requested a review from a team as a code owner March 21, 2024 16:22
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@cfi-gb cfi-gb force-pushed the ignore_xref_overlong_lines branch from 1fc3b0b to 10ff500 Compare March 21, 2024 16:24
@cfi-gb cfi-gb force-pushed the ignore_xref_overlong_lines branch from 10ff500 to 9c3bca4 Compare March 21, 2024 16:26
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (263d4ac) to head (9c3bca4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files          81       81           
  Lines        2736     2736           
  Branches      577      577           
=======================================
  Hits         2155     2155           
  Misses        440      440           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbrinkhoff mbrinkhoff enabled auto-merge (rebase) March 25, 2024 08:57
@mbrinkhoff mbrinkhoff merged commit 79e6a92 into main Mar 25, 2024
13 checks passed
@mbrinkhoff mbrinkhoff deleted the ignore_xref_overlong_lines branch March 25, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants