Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Various updates to the overlong description line plugin. #716

Merged
1 commit merged into from
Jun 12, 2024

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Jun 11, 2024

What

  • Make one exclusion more strict so that only one commonly used vuldetect script tag text is ignored / excluded
  • Make the end pattern regex more strict to use a trailing ";"
  • Add additional tag to the "test_line_too_long" test

Maybe merge before #717 so that both are included in the next planned release

Why

#712 added an exclusion but made the plugin to ignore the whole tag while we should only have this single exclusion and still do a warning of others

References

None

Checklist

  • Tests

@cfi-gb cfi-gb requested a review from a team as a code owner June 11, 2024 12:26
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@cfi-gb cfi-gb force-pushed the update_too_long_lines branch from 3f4e6b7 to 9f310cb Compare June 11, 2024 12:28
@cfi-gb cfi-gb force-pushed the update_too_long_lines branch from 9f310cb to 54a3895 Compare June 11, 2024 12:32
@cfi-gb cfi-gb force-pushed the update_too_long_lines branch from 54a3895 to c76a8d3 Compare June 11, 2024 12:37
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (15bfba2) to head (ddc993c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files          85       85           
  Lines        2829     2829           
  Branches      599      599           
=======================================
  Hits         2243     2243           
  Misses        443      443           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Make one exclusion more strict so that only one commonly used
  vuldetect script tag text is ignored / excluded
- Make the end pattern regex more strict to use a trailing ";"
- Add additional tag to the "test_line_too_long" test
@ghost ghost merged commit 61fb13d into main Jun 12, 2024
13 checks passed
@ghost ghost deleted the update_too_long_lines branch June 12, 2024 12:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant