Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: sort imports alphabetically #719

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Refactor: sort imports alphabetically #719

merged 1 commit into from
Jun 27, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2024

What

Sort the imports and the list of plugin classes in troubadix/plugins/__init__.py in alphabetical order.

Why

Looks better

References

Checklist

  • Tests

@ghost ghost self-requested a review as a code owner June 26, 2024 13:17
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (642e21f) to head (fa5e5e7).
Report is 5 commits behind head on main.

Current head fa5e5e7 differs from pull request most recent head 35d8d02

Please upload reports for the commit 35d8d02 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   79.45%   79.45%           
=======================================
  Files          85       85           
  Lines        2823     2823           
  Branches      596      596           
=======================================
  Hits         2243     2243           
  Misses        440      440           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbrinkhoff mbrinkhoff enabled auto-merge (rebase) June 27, 2024 22:13
@mbrinkhoff mbrinkhoff merged commit ce321b0 into main Jun 27, 2024
10 checks passed
@mbrinkhoff mbrinkhoff deleted the sort_imports branch June 27, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants