Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Check for creation date <= last modification date #799

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

n-thumann
Copy link
Member

@n-thumann n-thumann commented Feb 28, 2025

What

This PR adds a check to the creation date check to check whether the creation_date is smaller than / equal last_modification

Why

Because a VT cannot be modified before it has been created.

References

Jira: VTOPS-210
Depends on: greenbone/vulnerability-tests#16642

Checklist

  • Tests

Copy link

github-actions bot commented Feb 28, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA e9c3014.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

Conventional Commits Report

Type Number
Added 2
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (40ef76a) to head (e9c3014).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
troubadix/plugins/creation_date.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   79.81%   79.84%   +0.03%     
==========================================
  Files          87       87              
  Lines        3022     3027       +5     
  Branches      589      591       +2     
==========================================
+ Hits         2412     2417       +5     
  Misses        462      462              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-thumann n-thumann marked this pull request as ready for review March 3, 2025 07:23
@n-thumann n-thumann requested a review from a team as a code owner March 3, 2025 07:23
@n-thumann n-thumann enabled auto-merge March 3, 2025 07:27
@n-thumann n-thumann added the make release To trigger GitHub release action label Mar 3, 2025
@n-thumann n-thumann force-pushed the vtops-210_additional_creation_date_check branch from 2450269 to e9c3014 Compare March 3, 2025 10:06
@n-thumann n-thumann merged commit ba08df6 into main Mar 3, 2025
10 checks passed
@n-thumann n-thumann deleted the vtops-210_additional_creation_date_check branch March 3, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants