Allow to override build-args for container build 2nd gen #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calling workflow should be able to specify the build-args. For example it should be possible to use whatever gvm-libs base image version the calling workflow needs and shouldn't limit to oldstable and oldstable-edge. The change tries to be backwards compatible to still provide the old values if no build-args are passed.
bjoernricks
force-pushed
the
container-2nd-gen-build-args
branch
from
0ed97f8 to
4901c58
Compare
pascalholthaus
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow to override build-args for container build 2nd gen
Why
The calling workflow should be able to specify the build-args. For example it should be possible to use whatever gvm-libs base image version the calling workflow needs and shouldn't limit to oldstable and oldstable-edge.
The change tries to be backwards compatible to still provide the old values if no build-args are passed.
References
https://jira.greenbone.net/browse/GEA-791