Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

feat: release pipeline #97

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: release pipeline #97

wants to merge 11 commits into from

Conversation

yihong0618
Copy link
Contributor

No description provided.

@yihong0618 yihong0618 changed the title Hy/release feat: release pipeline Sep 6, 2022
@yihong0618
Copy link
Contributor Author

we need to retrigger commit pipeline and pr pipeline after this PR merge.
I change the shell arg name~

@@ -0,0 +1,21 @@
#!/bin/bash -l
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't concourse/scripts/test.sh be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

# build wheel
pip3 wheel . -w ../greenplumpython_artifacts
popd
tar -czf greenplumpython_artifacts/greenplumpython.tar.gz greenplumpython_artifacts/*.whl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So user needs to install psycopg2 manually?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will be the full name of the wheel file on different platforms? On my arch, it is:

greenplum_python-1.0.0b2-py3-none-any.whl

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do a simple test here? Just install the wheel and do a import test.

/home/gpadmin/greenplumpython_src/concourse/scripts/test.sh"
;;
/home/gpadmin/greenplumpython_src/concourse/scripts/test_and_build.sh"
;;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces at the end should be removed.

Copy link

@stkim1 stkim1 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces at the end should be removed.

Just as thorough as back in the days. 😉

Copy link
Collaborator

@beeender beeender Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am a heartless tail-space-finding machine.

@@ -56,6 +56,27 @@ on_error:
alert_type: errored
#@ end

#! Release trigger. For dev pipelines. No webhook
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For dev pipelines. No webhook

Is the comment correct?

unpack: true
- put: #@ conf["release_bin"]
params:
file: #@ conf["res_intermediates_bin"] + "/greenplumpython_*_*.tar.gz"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work since the unpacked file will be a .whl file
You could change the release bucket and test it.

source:
bucket: pivotal-gpdb-concourse-resources-prod
json_key: ((concourse-gcs-resources-service-account-key))
regexp: greenplumpython/released/greenplumpython-(.*).tar.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be tar.gz

#! Release trigger. For dev pipelines. No webhook
#@ def release_trigger(res_map):
#@ add_res_by_name(res_map, "greenplumpython_commit")
#@ add_res_by_name(res_map, "greenplumpython_release")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are line 61 & 62 needed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants