-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log message if jupyter not found instead of json-readtable-error #156
base: master
Are you sure you want to change the base?
Conversation
I just tested, and It still fails with:
This is from |
@nanounanue #135 definitely has multiple causes. This seems to fix only one of them. |
@dcherian As far as I can tell, all the other cases of Is it strictly relevant to this github issue that Is there a reason not to merge this? Can I help get it merged somehow? I should say, I personally have used |
@nanounanue Exactly what did you test? (I expect you tested a different bug: for example, a bug discussed in #135 maybe?) |
I've updated the description to add steps to reproduce. |
Note the reason syl20bnr/spacemacs#9941 is closed is that this upstream bug exists. |
To reproduce (from
emacs -Q
):ob-ipython
is installed and(require 'ob-ipython)
..org
fileExpect: No error
Got:
File mode specification error: (json-readtable-error 47)
This makes ob-ipython
message
rather than fail with ajson-readtable-error
(whose origin and cause are not so obvious) if auto-configuring jupyter kernels fails because (for example) jupyter is not installed. The message includes both the shell command and the output of that command.Related to #135 -- I don't think I could say it fixes it because I'm not sure that's a single issue, more of a self-help thread maybe...
The reason I personally want this is that it prevents issues like this, which occur even when the user isn't intending to use
ob-ipython
at all: syl20bnr/spacemacs#9941