Skip to content

Writing output of tutorials to a folder #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

miguelmaso
Copy link

Hi, I started using Julia and Gridap a few weeks ago. The tutorials are very handy.

I've noticed that the output files are somewhat messy in the notebooks directory, and sometimes the outputs from different tutorial are mixed up.

This PR is a proposal for a more structured output. The main change is to add an output_path folder and replacing it with the notebook prefix.

@JordiManyer
Copy link
Member

Hi @miguelmaso. Thank you for this, I've been putting it off for too long... I don't know if it can work, but maybe DrWatson can make your life easier by providing relative paths to the folder you want.

@miguelmaso
Copy link
Author

It works. Here you can see an example of the newly created notebooks. This makes it easier for new users like me to use
image

@miguelmaso miguelmaso marked this pull request as draft July 11, 2025 12:11
@miguelmaso
Copy link
Author

Marking as draft, since if it is found interesting, it should be applied to all the notebooks

@JordiManyer
Copy link
Member

Does it work if you just run the scripts in src, or does it error?

@miguelmaso
Copy link
Author

Does it work if you just run the scripts in src, or does it error?

julia> cd("src")
julia> include("poisson.jl")
(["output_path/results.vtu"],)

@JordiManyer
Copy link
Member

Then I guess you can go ahead and do it for all tutorials. Thank you!

@miguelmaso
Copy link
Author

miguelmaso commented Jul 22, 2025

Now it's ready for review. Feel free to merge it or to close

Summary of the PR

  • Every notebook prints output to a folder
  • Once notebooks are built, the output folder is named according to the tutorial number

My summary of the tutorials

  • t001 ✔️
  • t002 ✔️
  • t003 ✔️
  • t004 ✔️
  • t005 ✔️
  • t006 ✔️
  • t007 ✔️
  • t008 ✔️
  • t009 ✔️
  • t010 ✔️
  • t011 ✔️
  • t012 ✔️
  • t013 ✔️
  • t014 ✔️
  • t015 ✔️
  • t016 Poisson distributed: I don't have installed GridapDistributed (out of the scope of this PR)
  • t017 ✔️
  • t018 ✔️
  • t019 TopOpt: test takes too long (out of the scope of this PR)
  • t020 ❌ Poisson unfitted: error at cell 4: cutgeo = cut(bgmodel,geo3): QHULL WRAPPER is not properly loaded (out of the scope of this PR)
  • t021 ✔️
  • t022 ✔️
  • t023 ✔️
  • t024 ✔️
  • t025 ✔️
  • t026 ✔️
  • t027 ✔️

@miguelmaso miguelmaso marked this pull request as ready for review July 22, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants