Use the same host as origin for single-server setups #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is intended to determine if a Grist installation is a single URL installation or not. If it is, we can serve URLs from the same source as the browser request.
This should handle the most common case of a single Grist site with a single server, removing the need for the user to set up APP_HOME_URL in this case.
jordigh
force-pushed
the
jordigh/app-home-url
branch
2 times, most recently
from
56be4f8 to
31f41d9
Compare
These tests are for single-server setups that don't need this setting.
jordigh
force-pushed
the
jordigh/app-home-url
branch
from
fb6de66 to
72e6c92
Compare
paulfitz
reviewed
Feb 10, 2025
Spoffy
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Previously when we've talked about changes to APP_HOME_URL, we came to the conclusion it would be better if the frontend just used the current domain anyway:
As there's issues with reverse proxies not passing the Host header through, and the backend getting confused about what domain it's hosted on.
(Not sure if this is helpful, just relevant context)
jordigh
force-pushed
the
jordigh/app-home-url
branch
from
72e6c92 to
ae1902f
Compare
jordigh
changed the title
jordigh
force-pushed
the
jordigh/app-home-url
branch
from
ae1902f to
12f0f11
Compare
Spoffy
requested changes
Feb 11, 2025
jordigh
force-pushed
the
jordigh/app-home-url
branch
from
8ede53d to
09befb7
Compare
Spoffy
approved these changes
Feb 11, 2025
|
@jordigh Hmm this landed before I got to post this but: I ran a version of this PR against our saas tests (since it touches url handling which is fiddly) and there were some failures https://phab.getgrist.com/harbormaster/unit/20870/. I expect there may be small things to patch up, didn't see any red flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Self-hosters often immediately face an obstacle by not setting
APP_HOME_URLand getting a broken installation. There is no reason why this URL should be set in the most common case of a single server.Proposed solution
We check to see if the user has not set
APP_HOME_URLor encoded organisations as subdomains. In that case, we serve back the same origin as what we obtained from the browser request.Has this been tested?
I removed the
APP_HOME_URLsetting from the tests that didn't need it and they still pass.