support more options for SQLite connection #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic connection parameters used to open documents hasn't been touched in a long time. This adds support for WAL mode, or default mode with SYNCHRONOUS=full. Use `GRIST_SQLITE_MODE=wal` or `GRIST_SQLITE_MODE=sync` for this new behavior. Default is unchanged. WAL mode is not recommended for Desktop, or similar situations where you may habitually interact with .grist files managed by the Grist application on the file system. If all interaction is via the API, it should be a fine mode to use. The sync mode is a candidate for use on the Desktop.
@georgegevoian I've added a brief README entry. Would like to hold off pushing people to this until we've got some more experience with it (e.g. use in our SaaS staging). |
dsagal
reviewed
Mar 11, 2025
| @@ -72,6 +72,11 @@ export class AppSettings { | |||
| } else if (query.defaultValue !== undefined) { | |||
| this._value = query.defaultValue; | |||
| } | |||
| if (query.acceptedValues && this._value) { | |||
| if (query.acceptedValues.every(v => v !== this._value)) { | |||
There was a problem hiding this comment.
Would be clearer: !query.acceptedValues.includes(this._value)
| @@ -303,6 +303,7 @@ Grist can be configured in many ways. Here are the main environment variables it | |||
| | GRIST_SESSION_DOMAIN | if set, associates the cookie with the given domain - otherwise defaults to GRIST_DOMAIN | | |||
| | GRIST_SESSION_SECRET | a key used to encode sessions | | |||
| | GRIST_SKIP_BUNDLED_WIDGETS | if set, Grist will ignore any bundled widgets included via NPM packages. | | |||
| | GRIST_SQLITE_MODE | if set to `wal`, use SQLite in [WAL mode](https://www.sqlite.org/wal.html), if set to `sync`, use SQLite with [SYNCHRONOUS=full](https://www.sqlite.org/pragma.html#pragma_synchronous) | |||
There was a problem hiding this comment.
Should we say what the default mode is?
|
|
||
| /** | ||
| * Make a backup of the given document using either an already | ||
| * open connection, or a fresh one if to existing connection is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic connection parameters used to open documents haven't been touched in a long time. This adds support for WAL mode, or default mode with SYNCHRONOUS=full.
Use
GRIST_SQLITE_MODE=walorGRIST_SQLITE_MODE=syncfor this new behavior. Default is unchanged.WAL mode is not recommended for Desktop, or similar situations where you may habitually interact with .grist files managed by the Grist application on the file system. If all interaction is via the API, it should be a fine mode to use.
The sync mode is a candidate for use on the Desktop.