Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarity on how to add openrouter for llm-support #1509

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

lshalon
Copy link
Contributor

@lshalon lshalon commented Mar 12, 2025

Context
This PR updates the README to include documentation for OpenRouter integration, which allows users to access various LLM providers through a single API interface.

Proposed solution
Added clear documentation in the README explaining how to set up and use OpenRouter as an alternative LLM provider. This includes configuration steps, API key setup, and examples of how to select different models through the OpenRouter interface.

Related issues
N/A

Has this been tested?
👍

@jordigh
Copy link
Contributor

jordigh commented Mar 12, 2025

May I suggest a separate PR for the formatting changes?

@lshalon
Copy link
Contributor Author

lshalon commented Mar 12, 2025

@jordigh updated per your comment!

@lshalon lshalon force-pushed the readme-claude-and-other-support branch from c7c291d to 0d0b3f2 Compare March 13, 2025 01:58
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lshalon ! It reads well and looks helpful. Thanks for tweaking to point out it isn't the only way to use Claude. My one remaining qualm is that it still reads like a pitch for OpenRouter, and once landed, it will sound like that pitch is coming from Grist maintainers - and we really don't have an opinion on OpenRouter one way or another. Could you, just after the "## Using Grist ..." and a little "(Instructions contributed by @lshalon)" preamble? With that context for readers, I am comfortable landing it and grateful for your work in prepping it.

@lshalon lshalon force-pushed the readme-claude-and-other-support branch from 0d0b3f2 to 6738fd0 Compare March 13, 2025 13:49
@lshalon
Copy link
Contributor Author

lshalon commented Mar 13, 2025

@paulfitz Thanks! Let me know how it looks now?

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lshalon !

@paulfitz paulfitz merged commit 914ec19 into gristlabs:main Mar 13, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants