add missing error handlers to some pieces of middleware #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user reported a session error causing Grist to crash: https://community.getgrist.com/t/a-template-for-self-hosting-grist-with-traefik-and-docker-compose/856/28 The underlying error could be some cookie-related muddle with domain configuration, but it should just result in a error being issued as a response to a request, and not bring down the server. By forcing `req.session` to null artificially in the code and watching what breaks, I was able to replicate the symptoms. The middleware added here converts a server crash to an error response.
paulfitz
force-pushed
the
paulfitz/early-errors
branch
from
f8c3005 to
08f228c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported a session error causing Grist to crash: https://community.getgrist.com/t/a-template-for-self-hosting-grist-with-traefik-and-docker-compose/856/28
The underlying error could be some cookie-related muddle with domain configuration, but it should just result in a error being issued as a response to a request, and not bring down the server.
By forcing
req.sessionto null artificially in the code and watching what breaks, I was able to replicate the symptoms. The middleware added here converts a server crash to an error response.