Modernize the whole lib #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... using hatch
no more .PHONY targets!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @berhalak , @dsagal ,
The goal of this PR is not only to fix #4 , it's also to make contributing easier and restore trust of the community into this lib (probably also closing #5 ).
As you can see, the Github CI is passing for all currently supported Python versions, and modern tooling has been setup. The only thing I was not able to test is packaging/distribution, but it should work out-of-the box as I just copy/pasted some configuration from other projects.
This is of course only the beginning, as something could also be done with
ruff, setting up aCONTRIBUTING.mdfile, more docs...Let me know what you think about it!