cleanup: replace dial with newclient #8196

janardhanvissa · 2025-03-24T12:51:07Z

addresses: #7049

RELEASE NOTES: None

arjan-bal · 2025-04-09T08:48:43Z

Is this PR ready for review?

janardhanvissa · 2025-04-14T14:12:14Z

Is this PR ready for review?

yes, please

This reverts commit 79f6f35.

arjan-bal

There are a lot of unnecessary log message changes added in this PR. This makes it really hard to spot and review actual code changes.

arjan-bal · 2025-04-28T09:27:50Z

balancer/pickfirst/pickfirst_ext_test.go

-		t.Fatalf("Failed to create new client: %v", err)
+		t.Fatalf("grpc.NewClient(%q) = %v", lis.Addr().String(), err)


Please revert.

These log messages are suggested by Easwar's in other PR. Please see the discussion using the below links.

#7967 (comment)
#7967 (comment)

I don't think Easwar expected you to change log messages throughout the entire repo. The log messages are relatively harmless and can be fixed incrementally when people work on these parts of the codebase. Fixing them in a PR with real code changes makes it hard for reviewers to focus on the important parts.

arjan-bal · 2025-04-28T09:28:36Z

balancer/grpclb/grpclb_test.go

Please revert this file as all the changes are only in error messages.

arjan-bal · 2025-04-28T09:29:25Z

balancer/endpointsharding/endpointsharding_test.go

@@ -166,7 +165,7 @@ func (s) TestEndpointShardingBasic(t *testing.T) {
 	}
 	cc, err := grpc.NewClient(mr.Scheme()+":///", dOpts...)
 	if err != nil {
-		log.Fatalf("Failed to create new client: %v", err)


Please only change log to t, the error message is fine.

arjan-bal · 2025-04-28T09:30:31Z

balancer/rls/balancer_test.go

Please revert changes in this file as they are only error message changes.

arjan-bal · 2025-04-28T09:30:44Z

balancer/rls/balancer_test.go

Please revert changes in this file as they are only error message changes.

arjan-bal · 2025-04-28T09:40:15Z

xds/test/eds_resource_missing_test.go

Please revert.

arjan-bal · 2025-04-28T09:40:54Z

xds/server_ext_test.go

Please revert.

arjan-bal · 2025-04-28T09:41:12Z

xds/internal/xdsclient/tests/fallback_test.go

Please revert.

arjan-bal · 2025-04-28T09:42:30Z

test/channelz_test.go

@@ -308,7 +308,7 @@ func (s) TestCZTopChannelRegistrationAndDeletionWhenDialFail(t *testing.T) {
 	// Make dial fails (due to no transport security specified)
 	_, err := grpc.NewClient("fake.addr")
 	if err == nil {
-		t.Fatal("expecting dial to fail")
+		t.Fatalf("grpc.NewClient() failed: %v", err)


The message being replaced was the opposite, please fix.

arjan-bal · 2025-04-28T09:42:57Z

test/clientconn_state_transition_test.go

Please revert.

arjan-bal · 2025-04-28T09:49:13Z

stats/stats_test.go

@@ -274,7 +274,6 @@ func (te *test) clientConn() *grpc.ClientConn {
 	}
 	opts := []grpc.DialOption{
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
-		grpc.WithBlock(),


If you are removing WithBlock, you need to ensure the clientconn is ready before the function returns it. I ssupect this is the reason for the race conditions that you're seeing. Please use cc.Connect and testutils.AwaitState here to restore the behviour.

Thanks for pointing that out — you're absolutely right. Removing WithBlock without ensuring the connection is ready was likely the cause of the race conditions. I've now updated the code to call cc.Connect() and use testutils.AwaitState to properly wait for Ready before returning. Apologies for overlooking this earlier!

arjan-bal · 2025-04-28T09:49:48Z

stats/stats_test.go

+func checkPickerUpdated(t *testing.T, d *gotData, e *expectedData) {
+	var (
+		ok bool
+		st *stats.PickerUpdated
+	)
+	if st, ok = d.s.(*stats.PickerUpdated); !ok {
+		t.Fatalf("got %T, want PickerUpdated", d.s)
+	}
+	if d.ctx == nil {
+		t.Fatalf("d.ctx = nil, want <non-nil>")
+	}
+	st.IsClient() // TODO remove this.
+}


Please revert any assertion changes, we don't want to change the test logic.

codecov · 2025-04-29T12:16:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (b0d1203) to head (6fb73b9).
Report is 39 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8196      +/-   ##
==========================================
+ Coverage   82.06%   82.16%   +0.09%     
==========================================
  Files         410      417       +7     
  Lines       40233    41356    +1123     
==========================================
+ Hits        33018    33979     +961     
- Misses       5854     5950      +96     
- Partials     1361     1427      +66

Files with missing lines	Coverage Δ
credentials/insecure/insecure.go	`81.81% <ø> (ø)`
dialoptions.go	`90.80% <ø> (ø)`

... and 95 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

janardhanvissa · 2025-04-29T12:26:48Z

I've addressed all the comments by reverting the changes related to log message updates and fixing the race condition by calling cc.Connect() and using AwaitState to wait for the READY state.

vinothkumarr227 · 2025-05-02T12:06:56Z

@arjan-bal I think Janardhan has reverted the unnecessary changes in the PR. It should be ready for review now.

janardhankrishna-sai added 3 commits March 24, 2025 12:47

replacing dial with newclient

8ccd175

updating stats event count

8151579

update checkClientStats

7e18f5a

updating TestGRPCNewClientWithDNSAndProxy

1554a99

updating log from dial to grpc.NewClient()

d672f29

janardhanvissa force-pushed the replacing-dial-to-newclient branch from 6458128 to d672f29 Compare April 23, 2025 07:21

janardhanvissa and others added 3 commits April 23, 2025 12:58

Removing conflict file

79f6f35

Revert "Removing conflict file"

da31f15

This reverts commit 79f6f35.

revert conflict file

6b913fa

arjan-bal requested changes Apr 28, 2025

View reviewed changes

arjan-bal assigned janardhanvissa Apr 28, 2025

arjan-bal requested changes Apr 28, 2025

View reviewed changes

addressing review comments

6fb73b9

janardhankrishna-sai added 2 commits April 29, 2025 12:44

replacing log to t

1dff27f

reverting client.go

92ab1a7

janardhanvissa removed their assignment Apr 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup: replace dial with newclient #8196

cleanup: replace dial with newclient #8196

janardhanvissa commented Mar 24, 2025

arjan-bal commented Apr 9, 2025

janardhanvissa commented Apr 14, 2025

arjan-bal left a comment

arjan-bal Apr 28, 2025

janardhanvissa Apr 28, 2025

arjan-bal Apr 29, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

arjan-bal Apr 28, 2025

janardhanvissa Apr 29, 2025

arjan-bal Apr 28, 2025 •

edited

Loading

janardhanvissa Apr 29, 2025

codecov bot commented Apr 29, 2025

janardhanvissa commented Apr 29, 2025

vinothkumarr227 commented May 2, 2025

		t.Fatalf("Failed to create new client: %v", err)
		t.Fatalf("grpc.NewClient(%q) = %v", lis.Addr().String(), err)

cleanup: replace dial with newclient #8196

Are you sure you want to change the base?

cleanup: replace dial with newclient #8196

Conversation

janardhanvissa commented Mar 24, 2025

arjan-bal commented Apr 9, 2025

janardhanvissa commented Apr 14, 2025

arjan-bal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arjan-bal Apr 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 29, 2025

Codecov Report

janardhanvissa commented Apr 29, 2025

vinothkumarr227 commented May 2, 2025

arjan-bal Apr 28, 2025 •

edited

Loading