Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS Generator Identifier when name is camel case #1227

Closed
wants to merge 4 commits into from
Closed

Fix JS Generator Identifier when name is camel case #1227

wants to merge 4 commits into from

Conversation

nnnnoel
Copy link
Contributor

@nnnnoel nnnnoel commented Apr 22, 2022 •
edited
Loading

This PR fixes JS Generator when field name is camel case
protocolbuffers/protobuf-javascript#17

protobuf PR: protocolbuffers/protobuf-javascript#3

example

message Message {
    int32 someCamelCaseMessage = 1;
}

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 22, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@sampajano
Copy link
Collaborator

Thank you so much for taking the initiative to fix this both in protobuf and here!

I'll probably take a look after the protobuf change is approved! :) Please ping the thread here once it is. Thanks! :)

@nnnnoel
Copy link
Contributor Author

nnnnoel commented Oct 20, 2022

I don't know why protobuf PR has closed.
but I also close this PR because of protocolbuffers/protobuf-javascript#3

@nnnnoel nnnnoel closed this Oct 20, 2022
@sampajano
Copy link
Collaborator

Ahh not sure about protobuf.. Thanks for the update anyways tho..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnnnoel @sampajano @grpc-kokoro