Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllustratedMessage component #542

Merged
merged 13 commits into from
Dec 5, 2024
Merged

Conversation

victortrinh2
Copy link
Collaborator

@victortrinh2 victortrinh2 commented Dec 4, 2024

Adding the IllustratedMessage to Hopper

Issue: https://workleap.atlassian.net/browse/DS-207

Description

Had to add the Image & SvgImage also to the make the component work properly.

How to test

Check out the storybook and the documentation.

Screenshots

Image

Screenshot 2024-12-04 at 5 47 37 PM

SvgImage

Screenshot 2024-12-04 at 5 48 51 PM

IllustratedMessage

image

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 44cbca2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for wl-hopper ready!

Name Link
🔨 Latest commit 44cbca2
🔍 Latest deploy log https://app.netlify.com/sites/wl-hopper/deploys/67520e8b3fc2850008db2520
😎 Deploy Preview https://deploy-preview-542--wl-hopper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@victortrinh2 victortrinh2 marked this pull request as ready for review December 5, 2024 14:01
Copy link
Contributor

github-actions bot commented Dec 5, 2024

View Storybook

@victortrinh2 victortrinh2 merged commit b2211df into main Dec 5, 2024
9 checks passed
@victortrinh2 victortrinh2 deleted the feature/DS-207_IllustratedMessage branch December 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants