Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Component Documentation #550

Merged
merged 15 commits into from
Dec 13, 2024
Merged

Conversation

alexasselin008
Copy link
Member

@alexasselin008 alexasselin008 commented Dec 13, 2024

  • We want the examples to be easily copy pastable. So we need to make sure that the examples are easy to understand, and don't have unnecessary properties or html elements.
  • ErrorMessage and HelperMessage aren't components usable on their own, they are parts we have internally. So i kept the doc, but made a special section at the bottom
  • Added description to component and token pages, so the description are well shown when copy pasting an article to someone in a slack message
  • Resolved some typing issues that were complexifying user code too much

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: c1da40d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hopper-ui/styled-system Patch
@hopper-ui/components Patch
@hopper-ui/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for wl-hopper ready!

Name Link
🔨 Latest commit c1da40d
🔍 Latest deploy log https://app.netlify.com/sites/wl-hopper/deploys/675ca0b9bde7b4000896dea6
😎 Deploy Preview https://deploy-preview-550--wl-hopper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexasselin008 alexasselin008 marked this pull request as ready for review December 13, 2024 20:27
Copy link
Contributor

github-actions bot commented Dec 13, 2024

View Storybook

@alexasselin008 alexasselin008 merged commit 6d15025 into main Dec 13, 2024
10 checks passed
@alexasselin008 alexasselin008 deleted the feature/DS-507_components branch December 13, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant