Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Fixes of different PRs merged #565

Merged
merged 11 commits into from
Jan 9, 2025
Merged

Conversation

alexasselin008
Copy link
Member

@alexasselin008 alexasselin008 commented Jan 6, 2025

  • Remove unecessary Slots
  • Fix inputRef typings so a cast is no longer necessary
  • Fixed some slots issues that were causing crashes or console warnings
  • Resolved an issue preventing the addition of a custom renderEmptyState on a Listbox within a ComboBox.
  • Simplified the inputRef type to enhance usability across multiple components.

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: cfa45ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hopper-ui/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for wl-hopper ready!

Name Link
🔨 Latest commit cfa45ea
🔍 Latest deploy log https://app.netlify.com/sites/wl-hopper/deploys/677ef313d8f44b0008a2654b
😎 Deploy Preview https://deploy-preview-565--wl-hopper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

View Storybook

@alexasselin008 alexasselin008 changed the title [WIP] Remove all unecessary slots to test Review Fixes of different PRs merged Jan 8, 2025
@alexasselin008 alexasselin008 marked this pull request as draft January 8, 2025 15:25
@alexasselin008 alexasselin008 marked this pull request as ready for review January 8, 2025 21:37
Copy link
Collaborator

@victortrinh2 victortrinh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! 💯

@alexasselin008 alexasselin008 merged commit d29ca78 into main Jan 9, 2025
10 checks passed
@alexasselin008 alexasselin008 deleted the feature/jan_review branch January 9, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants