[DS-219] Add SegmentedControl component #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fdf3904 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for wl-hopper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
victortrinh2
commented
Jan 8, 2025
packages/components/src/SegmentedControl/src/SegmentedControl.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/SegmentedControl/src/SegmentedControl.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/SegmentedControl/src/SegmentedControlItem.module.css
Show resolved
Hide resolved
victortrinh2
force-pushed
the
feature/DS-219_SegmentedControl
branch
from
eb590da to
a5cf027
Compare
There was a problem hiding this comment.
The animation in the "preview" example looks weird. When selecting an item for the first time (if no button was selected before), there is an animation that makes it appear from the left, but it should just select without the sliding animation
In fact it's only noticeable on the left most one
packages/components/src/SegmentedControl/src/SegmentedControl.module.css
Outdated
Show resolved
Hide resolved
packages/components/src/SegmentedControl/src/SegmentedControl.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/SegmentedControl/src/SegmentedControlItem.module.css
Outdated
Show resolved
Hide resolved
packages/components/src/SegmentedControl/src/SegmentedControl.module.css
Outdated
Show resolved
Hide resolved
packages/components/src/SegmentedControl/tests/jest/SegmentedControl.test.tsx
Outdated
Show resolved
Hide resolved
victortrinh2
force-pushed
the
feature/DS-219_SegmentedControl
branch
from
a5cf027 to
ba5e3eb
Compare
packages/components/src/SegmentedControl/src/SegmentedControlItem.module.css
Outdated
Show resolved
Hide resolved
packages/components/src/SegmentedControl/src/SegmentedControlItem.module.css
Show resolved
Hide resolved
packages/components/src/SegmentedControl/src/SegmentedControlItem.module.css
Show resolved
Hide resolved
alexasselin008
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the segmented control component