New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: [HOP-48] Building SVGs #93

Merged

alexasselin008 merged 50 commits into main from feature/HOP-48-icons

Nov 21, 2023

Contributor

vicky-comeau commented Nov 14, 2023 •

edited

Loading

This is the package for SVGs only, no react yet. It builds, optimizes and outputs SVGs
Chromatic tests were not added. These will be added for @hopper-ui/icons (component version)
Jest tests were added.


          Feature: [HOP-48] Building SVGs

changeset-bot bot commented Nov 14, 2023 •

edited

Loading

🦋 Changeset detected

Latest commit: 6a68e3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@hopper-ui/svg-icons	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify bot commented Nov 14, 2023 •

edited

Loading

✅ Deploy Preview for wl-hopper ready!

Name	Link
🔨 Latest commit	`6a68e3e`
🔍 Latest deploy log	https://app.netlify.com/sites/wl-hopper/deploys/655cc5b81bdb4b000836ab59
😎 Deploy Preview	https://deploy-preview-93--wl-hopper.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alexasselin008 reviewed

View reviewed changes

packages/svgs/package.json Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/package.json Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/package.json Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/package.json Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/package.json Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/helper.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/load-icons.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/load-icons.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/load-icons.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/load-icons.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/constants.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/load-icons.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/load-icons.ts Outdated Show resolved Hide resolved

alexasselin008 reviewed

View reviewed changes

packages/svgs/src/scripts/load-icons.ts Outdated Show resolved Hide resolved

alexasselin008 and others added 13 commits

November 14, 2023 16:50


          refactor optimize-icons

7d08625


          PR fixes for svgs

dadaecb


          small cleanup

2e7fd7b


          remove duplicates function


          Merge branch 'main' of https://github.com/gsoft-inc/wl-hopper into fe…

…ature/HOP-48-icons


          update

fd4f656


          jest tests

1d89f30


          tentative jest fix

d06d80d


          add tests

72c2c95


          Update add icon

8d06d59


          Merge branch 'feature/HOP-48-icons' of https://github.com/gsoft-inc/w…

15498a3

…l-hopper into feature/HOP-48-icons


          update test file


          Remove checks that are now unit tests, move src/scripts to scripts, u…

cb7829d

…pdate dependencies, remove unused dependencies

alexasselin008 and others added 9 commits

November 16, 2023 15:26


          test

a6f0e9e


          clear cache for svgs

f505774


          Update ci.yml

89c2e25


          remove caching

e4bcbe3


          Merge branch 'feature/HOP-48-icons' of https://github.com/gsoft-inc/w…

88df4d1

…l-hopper into feature/HOP-48-icons


          update test

9f313be


          add logging

96bcf24


          remove race condition

0797fcc


          add more logging

2a36a6f

alexasselin008 closed this

alexasselin008 reopened this

alexasselin008 and others added 6 commits

November 17, 2023 14:06


          Update ci.yml

d43d824


          add nvmrc file

b3169e4


          Merge branch 'feature/HOP-48-icons' of https://github.com/gsoft-inc/w…

a2098ca

…l-hopper into feature/HOP-48-icons


          update scripts

f8aa0ae


          remove unused dependency


          re-add ts-node

9ca5328

franckgaudin reviewed

View reviewed changes

packages/tokens/package.json Show resolved Hide resolved

vicky-comeau and others added 2 commits

November 17, 2023 16:42


          fixed icons

7c7af0b


          fix lint

c2e0507

fraincs previously approved these changes

View reviewed changes


          Updated EyeHidden svg

558f41c

vicky-comeau dismissed fraincs’s stale review via

558f41c

November 21, 2023 02:46

vicky-comeau and others added 4 commits

November 20, 2023 22:05


          Fixed linting issue

a6e772f


          Update packages

fbc4555


          rename package

883776f


          commit pnpm-lock

6a68e3e

franckgaudin approved these changes

View reviewed changes

alexasselin008 merged commit 59d57e2 into main

5 checks passed

alexasselin008 deleted the feature/HOP-48-icons branch

November 21, 2023 15:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet