Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "add-depsdev-on-ingest" flag info to cli store #2389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add "add-depsdev-on-ingest" flag info to cli store #2389

wants to merge 1 commit into from

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Dec 19, 2024

Description of the PR

Add "add-depsdev-on-ingest" flag info to cli store

Addressing #2385 (comment)

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@lumjjb lumjjb requested a review from jeffmendoza as a code owner December 19, 2024 19:11
@lumjjb lumjjb requested a review from pxp928 December 19, 2024 19:11
pxp928
pxp928 reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing in two more places. Otherwise looks good.

pkg/cli/store.go
@@ -70,6 +70,9 @@ func init() {
// the ingestor will query and ingest endoflife.date for EOL
set.Bool("add-eol-on-ingest", false, "if enabled, the ingestor will query and ingest endoflife.date for EOL data. Warning: This will increase ingestion times")

// the ingestor will query and ingest deps.dev data for scorecards and source association
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the flag here on guaccollect: https://github.com/guacsec/guac/blob/main/cmd/guacingest/cmd/root.go#L34

and guacone: https://github.com/guacsec/guac/blob/main/cmd/guacone/cmd/root.go#L34

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made changes

@pxp928 pxp928 added the needs-review Needs writer LGTM label Jan 6, 2025
mihaimaruseac
mihaimaruseac approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but need to add it to the other two places

@lumjjb lumjjb force-pushed the add-depsdevscan-clistore branch from 1c7830e to 639c80f Compare January 21, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

Assignees
No one assigned
Labels
needs-review Needs writer LGTM size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumjjb @mihaimaruseac @pxp928