Make Select display invalid state only if user has interacted, take 2
#1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a6e918 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
…acted" (…" This reverts commit 78fa8cb.
sndrs
force-pushed
the
revert-1756-revert-1733-ahe/select-invalid
branch
from
eede1a8 to
d2012b6
Compare
sndrs
changed the title
Select display invalid state only if user has interacted, take 2
|
"This PR was marked stale because it has been open for 30 days without activity. If nothing happens, it will be closed 3 days from now." |
|
This PR was closed because nothing happened for 3 days after becoming stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores and provides a fallback for @andrewHEguardian's original change from #1733.
If this is approved we can copy the solution to the rest of the input components.