Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom layout and make default layout respond to container #1820

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Nov 27, 2024

What are you changing?

  • add option to use a custom layout by exporting crossword parts as subcomponents of Crossword (Crossword.Grid etc)
  • make the default layout respond to its container

Why?

  • adds flexibility without harming the default experience (this will be useful in DCR where we have a fixed layout)
  • default layout will now scroll itself if necessary

Scrolling

image image

Custom layout

image

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Nov 27, 2024
@sndrs sndrs added this to the Decommission Frontend Rendering milestone Nov 27, 2024
@sndrs sndrs self-assigned this Nov 27, 2024
@sndrs sndrs requested a review from a team as a code owner November 27, 2024 16:28
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 7ad07e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Nov 27, 2024
@sndrs sndrs linked an issue Nov 27, 2024 that may be closed by this pull request
@sndrs sndrs force-pushed the sndrs/crosswords/custom-layouts branch from 7f81db9 to f2d36c5 Compare November 27, 2024 16:41
@sndrs sndrs force-pushed the sndrs/crosswords/custom-layouts branch from 23248de to 7ad07e3 Compare November 27, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

Export subcomponents to add consumer layout
1 participant