In the setup script, install yarn with npm
#6696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the recommendation cross platform. We'll already have npm through installing Node.
|
Size Change: 0 B Total Size: 2.1 MB ℹ️ View Unchanged
|
rupertbates
reviewed
Jan 16, 2025
| if linux && ! installed yarn; then | ||
| sudo apt-get install yarn | ||
| install_yarn() { | ||
| if ! installed yarn; then |
There was a problem hiding this comment.
Will this recognise if yarn is installed with Homebrew?
There was a problem hiding this comment.
Yes I think so. The installed function uses the hash utility, and I can see that it can understands utilities installed with homebrew. For example in bash:
bash-3.2$ which dev-nginx
/opt/homebrew/bin/dev-nginx
bash-3.2$ hash dev-nginx # no output == found it
bash-3.2$ hash dev-nginxssss
bash: hash: dev-nginxssss: not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
In the setup script install
yarnwithnpm.Why are you doing this?
This is the approach recommended by yarn. I'm looking at general improvements to the setup script and this is a first baby step.
How to test
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots