-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert original map to improve 10K #662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsiomkorzun
force-pushed
the
revert-map
branch
2 times, most recently
from
January 30, 2024 19:41
e2db649
to
5476523
Compare
No difference for the standard key set, but 10K key set is actually slower. Standard:
10K:
|
@gunnarmorling what time is for the current entry 29 Jan? I only see the time for 27 Jan. |
artsiomkorzun
force-pushed
the
revert-map
branch
from
January 31, 2024 09:59
f70a0fc
to
26d56aa
Compare
artsiomkorzun
force-pushed
the
revert-map
branch
from
January 31, 2024 10:08
99c0b6c
to
88bce1d
Compare
@gunnarmorling can you please test 413 case one more time? I picked up the compiler's setting from Thomas. Maybe something will change. |
Yes, looking much better now:
Also back to the previous level for 10K. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List:
./mvnw verify
and the project builds successfully./test.sh <username>
shows no differences between expected and actual outputs)calculate_average_<username>.sh
(make sure to match casing of your GH user name) and is executablecalculate_average_baseline.sh
Reverting map structure to restore 10K performance.