-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency material-ui #803
Comments
@guyellis About design, I was thinking about make something new with own components and css, no third party css libraries. This should be a long and complex issue, maybe an epic issue, I know, but this is a stuff that I really like it! Let me know what you think. |
@mateusmarquezini - what are the pros and cons of doing each? I see material-ui as an easy way to get a bunch of standardized controls that perform basic functionality at low cost. The maintenance of it is relatively low because that happens in their library and we are consumers. If we were to do our own would that increase the maintenance needed in this repo? I'm certainly open to change and I'd like to see more details around what you're proposing. Here's an idea: Why don't we upgrade Material-UI so that we're on the latest version. Then you take one of the components and restyle it as you suggested and we look at that and compare the pros and cons of the against the Material-UI version. What do you think? |
Hi @guyellis , sorry for the delay. |
Hey @mateusmarquezini - I just came across this article: https://levelup.gitconnected.com/material-ui-styled-components-fff4d345fb07 I think that might solve your concern. Style Components or custom CSS could be used like that. |
Hey, thanks @guyellis ! Yeah, it's something like that I was thinking about! |
Hi @guyellis ! Sorry for the delay but I'm working very hard on this issue! 😃 All these using Material UI components. As soon as possible, I'll post some stuff here for you check the changes, or if you want, you can run the application on branch |
No problem @mateusmarquezini - thanks for the update. If you want to do a PR for just the React and MaterialUI upgrade first and then the others that might make the PRs smaller and easier to reason about. If it's not possible to untangle that and the layout changes then don't worry about it and I'll wait for your PR. |
hi @guyellis , as you told me, I just opened a new PR only with Material UI and React dependencies updated. A lot of files was changed as you can see there. |
…ause there're two renderings on components
material-ui
is not showing up on outdated dependencies because it has moved to a scoped module under@material-ui
- we are on 0.x and the latest at the time of writing this is 4.xThere are some upgrade guides:
https://material-ui.com/guides/migration-v0x/
https://material-ui.com/guides/migration-v3/
The text was updated successfully, but these errors were encountered: