React and Material UI dependencies updated #843
Conversation
| const special5 = [...Array(9).keys()].map((a) => [1, a + 1]); | ||
| const special6 = [...Array(9).keys()].map((a) => [a + 1, 1]); // [1...9, 1] | ||
| const special7 = [...Array(9).keys()].map((a) => [a + 1, a + 1]); // [[1,1],...[9,9]] | ||
| const special1 = [...Array(9).keys()].map(a => [0, a + 1]); |
There was a problem hiding this comment.
I know that single parameter arrow functions allow for now parenthesis but I've setup the lint rules to always enforce parenthesis for all arrow functions in order to be consistent in style across the whole repo. I think that this is super easy and quick to fix by just running npm run lintfix
There was a problem hiding this comment.
Another point. If we decided to change this lint rule, we should do that as a single distinct and separate PR and not mix it with these upgrade changes.
There was a problem hiding this comment.
Before commit all these changes and open PR, I really forgot to run this command, but I just ran npm run lintfix and nothing was changed. Maybe there are new rules with the latest eslint version we have updated?
There was a problem hiding this comment.
Well, after some attempts, it worked!
|
@mateusmarquezini - nice - I like these changes. I made a couple of comments aimed at minimizing the number of changes in this PR. thanks. |
| @@ -24,8 +29,9 @@ class Keyboard extends React.Component { | |||
| }, {}); | |||
|
|
|||
| if (props.largeKeyboard) { | |||
There was a problem hiding this comment.
I've created 2 styles to apply here because I was getting an error before.
error: Cannot add property height, object is not extensible
So, here I only did a copy of them to buttonStyle.
There was a problem hiding this comment.
These changes look good to me. Feel free to merge when you're ready @mateusmarquezini
Ok @guyellis , thanks! |
ISSUE #803
PS: Don't close the issue because the layout improvements are in progress.