gvolpe · gvolpe · Sep 4, 2023 · Sep 3, 2023 · Sep 4, 2023
diff --git a/modules/alerts/src/main/scala/trading/alerts/Engine.scala b/modules/alerts/src/main/scala/trading/alerts/Engine.scala
@@ -1,10 +1,8 @@
 package trading.alerts
 
-import trading.commands.TradeCommand
 import trading.core.TradeEngine
 import trading.domain.Alert.{ TradeAlert, TradeUpdate }
 import trading.domain.AlertType.*
-import trading.domain.TradingStatus.*
 import trading.domain.*
 import trading.events.*
 import trading.lib.*

diff --git a/modules/alerts/src/main/scala/trading/alerts/Main.scala b/modules/alerts/src/main/scala/trading/alerts/Main.scala
@@ -10,13 +10,7 @@ import trading.state.TradeState
 
 import cats.effect.*
 import cats.syntax.all.*
-import dev.profunktor.pulsar.{
-  Consumer as PulsarConsumer,
-  Producer as PulsarProducer,
-  Pulsar,
-  SeqIdMaker,
-  Subscription
-}
+import dev.profunktor.pulsar.{ Consumer as PulsarConsumer, Producer as PulsarProducer, Pulsar, Subscription }
 import fs2.Stream
 
 object Main extends IOApp.Simple:

diff --git a/modules/core/src/main/scala/trading/core/TradeEngine.scala b/modules/core/src/main/scala/trading/core/TradeEngine.scala
@@ -11,8 +11,6 @@ import trading.events.TradeEvent.{ CommandExecuted, CommandRejected }
 import trading.lib.FSM
 import trading.state.TradeState
 
-import cats.Id
-
 object TradeEngine:
   // Event generation and trading switch
   val fsm = FSM.id[TradeState, TradeCommand | SwitchCommand, (EventId, Timestamp) => TradeEvent | SwitchEvent] {

diff --git a/modules/domain/jvm/src/main/scala/trading/domain/Symbol.scala b/modules/domain/jvm/src/main/scala/trading/domain/Symbol.scala
@@ -3,7 +3,6 @@ package trading.domain
 import trading.Newtype
 
 import cats.*
-import cats.derived.*
 import io.circe.*
 import io.github.iltotore.iron.*
 import io.github.iltotore.iron.cats.given

diff --git a/modules/domain/jvm/src/test/scala/trading/domain/SymbolSuite.scala b/modules/domain/jvm/src/test/scala/trading/domain/SymbolSuite.scala
@@ -2,7 +2,6 @@ package trading.domain
 
 import trading.domain.*
 import trading.domain.arbitraries.given
-import trading.domain.cogen.given
 
 import cats.kernel.laws.discipline.MonoidTests
 import weaver.FunSuite

diff --git a/modules/domain/jvm/src/test/scala/trading/ws/WsCodecSuite.scala b/modules/domain/jvm/src/test/scala/trading/ws/WsCodecSuite.scala
@@ -4,7 +4,6 @@ import trading.domain.*
 import trading.domain.generators.*
 
 import cats.effect.IO
-import cats.syntax.all.*
 import io.circe.parser.decode as jsonDecode
 import io.circe.syntax.*
 import org.scalacheck.Gen

diff --git a/modules/domain/shared/src/main/scala/trading/Newtype.scala b/modules/domain/shared/src/main/scala/trading/Newtype.scala
@@ -2,8 +2,6 @@ package trading
 
 import java.util.UUID
 
-import trading.domain.OrphanInstances.given
-
 import cats.{ Eq, Order, Show }
 import io.circe.{ Decoder, Encoder }
 import monocle.Iso
@@ -46,12 +44,7 @@ abstract class IdNewtype extends Newtype[UUID]:
   given IsUUID[Type]                = derive[IsUUID]
   def unsafeFrom(str: String): Type = apply(UUID.fromString(str))
 
-abstract class NumNewtype[A](using
-    eqv: Eq[A],
-    ord: Order[A],
-    shw: Show[A],
-    enc: Encoder[A],
-    dec: Decoder[A],
+abstract class NumNewtype[A: Decoder: Encoder: Eq: Order: Show](using
     num: Numeric[A]
 ) extends Newtype[A]:
 

diff --git a/modules/domain/shared/src/main/scala/trading/commands/ForecastCommand.scala b/modules/domain/shared/src/main/scala/trading/commands/ForecastCommand.scala
@@ -1,6 +1,6 @@
 package trading.commands
 
-import trading.domain.{ *, given }
+import trading.domain.*
 
 import cats.{ Applicative, Eq, Show }
 import cats.derived.*

diff --git a/modules/domain/shared/src/main/scala/trading/commands/SwitchCommand.scala b/modules/domain/shared/src/main/scala/trading/commands/SwitchCommand.scala
@@ -1,6 +1,6 @@
 package trading.commands
 
-import trading.domain.{ *, given }
+import trading.domain.*
 
 import cats.{ Applicative, Eq, Show }
 import cats.derived.*

diff --git a/modules/domain/shared/src/main/scala/trading/commands/TradeCommand.scala b/modules/domain/shared/src/main/scala/trading/commands/TradeCommand.scala
@@ -1,6 +1,6 @@
 package trading.commands
 
-import trading.domain.{ *, given }
+import trading.domain.*
 
 import cats.{ Applicative, Eq, Show }
 import cats.derived.*

diff --git a/modules/domain/shared/src/main/scala/trading/domain.scala b/modules/domain/shared/src/main/scala/trading/domain.scala
@@ -1,7 +1,6 @@
 package trading.domain
 
 import java.time.Instant
-import java.util.UUID
 
 import scala.concurrent.duration.FiniteDuration
 

diff --git a/modules/domain/shared/src/main/scala/trading/domain/AlertType.scala b/modules/domain/shared/src/main/scala/trading/domain/AlertType.scala
@@ -3,7 +3,7 @@ package trading.domain
 import cats.{ Eq, Show }
 import cats.derived.*
 import cats.syntax.all.*
-import io.circe.{ Decoder, Encoder, Json }
+import io.circe.{ Decoder, Encoder }
 
 enum AlertType derives Eq, Show:
   case StrongBuy, StrongSell, Neutral, Buy, Sell

diff --git a/modules/domain/shared/src/main/scala/trading/domain/OrphanInstances.scala b/modules/domain/shared/src/main/scala/trading/domain/OrphanInstances.scala
@@ -1,13 +1,11 @@
 package trading.domain
 
 import java.time.Instant
-import java.util.UUID
 
 import scala.concurrent.duration.{ Duration, FiniteDuration }
 
 import cats.*
 import cats.syntax.all.*
-import com.comcast.ip4s.*
 import io.circe.{ Decoder, Encoder }
 
 object OrphanInstances:

diff --git a/modules/domain/shared/src/main/scala/trading/domain/TradingStatus.scala b/modules/domain/shared/src/main/scala/trading/domain/TradingStatus.scala
@@ -3,7 +3,7 @@ package trading.domain
 import cats.{ Eq, Show }
 import cats.derived.*
 import cats.syntax.all.*
-import io.circe.{ Decoder, Encoder, Json }
+import io.circe.{ Decoder, Encoder }
 
 enum TradingStatus derives Eq, Show:
   case On, Off

diff --git a/modules/domain/shared/src/main/scala/trading/domain/VoteResult.scala b/modules/domain/shared/src/main/scala/trading/domain/VoteResult.scala
@@ -3,7 +3,7 @@ package trading.domain
 import cats.{ Eq, Show }
 import cats.derived.*
 import cats.syntax.all.*
-import io.circe.{ Decoder, Encoder, Json }
+import io.circe.{ Decoder, Encoder }
 
 enum VoteResult derives Eq, Show:
   case Up, Down

diff --git a/modules/domain/shared/src/main/scala/trading/events/AuthorEvent.scala b/modules/domain/shared/src/main/scala/trading/events/AuthorEvent.scala
@@ -1,6 +1,5 @@
 package trading.events
 
-import trading.commands.ForecastCommand
 import trading.domain.*
 
 import io.circe.Codec

diff --git a/modules/domain/shared/src/main/scala/trading/events/ForecastEvent.scala b/modules/domain/shared/src/main/scala/trading/events/ForecastEvent.scala
@@ -1,6 +1,5 @@
 package trading.events
 
-import trading.commands.ForecastCommand
 import trading.domain.*
 
 import io.circe.Codec

diff --git a/modules/domain/shared/src/main/scala/trading/events/SwitchEvent.scala b/modules/domain/shared/src/main/scala/trading/events/SwitchEvent.scala
@@ -1,7 +1,6 @@
 package trading.events
 
-import trading.commands.SwitchCommand
-import trading.domain.{ *, given }
+import trading.domain.*
 
 import cats.{ Applicative, Show }
 import cats.derived.*

diff --git a/modules/domain/shared/src/main/scala/trading/events/TradeEvent.scala b/modules/domain/shared/src/main/scala/trading/events/TradeEvent.scala
@@ -1,7 +1,7 @@
 package trading.events
 
 import trading.commands.TradeCommand
-import trading.domain.{ *, given }
+import trading.domain.*
 
 import cats.{ Applicative, Eq, Show }
 import cats.derived.*

diff --git a/modules/feed/src/main/scala/trading/feed/Feed.scala b/modules/feed/src/main/scala/trading/feed/Feed.scala
@@ -1,6 +1,7 @@
 package trading.feed
 
 import scala.concurrent.duration.*
+import scala.annotation.nowarn
 
 import trading.commands.*
 import trading.domain.*
@@ -50,6 +51,7 @@ object Feed:
 
     // This implementation is quite random, generating a lot of AuthorNotFound errors downstream
     // Prefer the ForecastFeed implementation (running directly from Main) for a more realistic simulation
+    @nowarn
     val forecasting: F[Unit] =
       forecastCommandListGen.replicateA(2).flatten.traverse_ { cmd =>
         import ForecastCommand.*

diff --git a/modules/feed/src/main/scala/trading/feed/ForecastFeed.scala b/modules/feed/src/main/scala/trading/feed/ForecastFeed.scala
@@ -1,38 +1,20 @@
 package trading.feed
 
-import java.time.Instant
 import java.util.UUID
 
 import scala.concurrent.duration.*
 
 import trading.commands.ForecastCommand
-import trading.core.AppTopic
 import trading.domain.*
 import trading.domain.generators.*
 import trading.events.*
-import trading.lib.{ *, given }
+import trading.lib.*
 
 import cats.effect.*
-import cats.effect.syntax.all.*
 import cats.syntax.all.*
-import dev.profunktor.pulsar.{ Producer as PulsarProducer, Pulsar, Subscription, Topic }
 import fs2.Stream
 
 object ForecastFeed:
-  private val sub =
-    Subscription.Builder
-      .withName("forecasts-gen")
-      .withType(Subscription.Type.Exclusive)
-      .build
-
-  private def settings[A: Shard](name: String) =
-    PulsarProducer
-      .Settings[IO, A]()
-      .withDeduplication
-      .withName(s"forecast-gen-$name-command")
-      .withShardKey(Shard[A].key)
-      .some
-
   // The randomness of randomUUID() seems better than that of Gen.uuid
   def makeCmdId = CommandId(UUID.randomUUID())
 

diff --git a/modules/feed/src/main/scala/trading/feed/Main.scala b/modules/feed/src/main/scala/trading/feed/Main.scala
@@ -3,7 +3,6 @@ package trading.feed
 import trading.commands.*
 import trading.core.AppTopic
 import trading.core.http.Ember
-import trading.domain.CommandId
 import trading.events.*
 import trading.lib.*
 

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/Config.scala b/modules/forecasts/src/main/scala/trading/forecasts/Config.scala
@@ -1,7 +1,5 @@
 package trading.forecasts
 
-import scala.concurrent.duration.*
-
 import trading.domain.{ *, given }
 
 import cats.effect.kernel.Async

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/Engine.scala b/modules/forecasts/src/main/scala/trading/forecasts/Engine.scala
@@ -5,11 +5,10 @@ import trading.domain.*
 import trading.events.{ AuthorEvent, ForecastEvent }
 import trading.forecasts.store.*
 import trading.lib.*
-import trading.lib.Consumer.{ Msg, MsgId }
+import trading.lib.Consumer.Msg
 
-import cats.effect.kernel.{ MonadCancelThrow, Resource }
+import cats.effect.kernel.MonadCancelThrow
 import cats.syntax.all.*
-import fs2.Stream
 
 trait Engine[F[_]]:
   def run: Msg[ForecastCommand] => F[Unit]

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/Main.scala b/modules/forecasts/src/main/scala/trading/forecasts/Main.scala
@@ -6,10 +6,9 @@ import trading.core.http.Ember
 import trading.events.*
 import trading.forecasts.cdc.*
 import trading.forecasts.store.*
-import trading.lib.{ *, given }
+import trading.lib.*
 
 import cats.effect.*
-import cats.effect.syntax.all.*
 import cats.syntax.all.*
 import dev.profunktor.pulsar.{ Producer as PulsarProducer, Pulsar, Subscription, Topic }
 import fs2.Stream

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/VotesHandler.scala b/modules/forecasts/src/main/scala/trading/forecasts/VotesHandler.scala
@@ -1,7 +1,5 @@
 package trading.forecasts
 
-import scala.concurrent.duration.*
-
 import trading.domain.*
 import trading.events.ForecastEvent
 import trading.forecasts.store.*

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/cdc/OutboxHandler.scala b/modules/forecasts/src/main/scala/trading/forecasts/cdc/OutboxHandler.scala
@@ -1,7 +1,5 @@
 package trading.forecasts.cdc
 
-import scala.concurrent.duration.*
-
 import trading.domain.*
 import trading.events.*
 import trading.lib.*

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/store/AuthorStore.scala b/modules/forecasts/src/main/scala/trading/forecasts/store/AuthorStore.scala
@@ -2,13 +2,11 @@ package trading.forecasts.store
 
 import trading.domain.*
 import trading.events.AuthorEvent
-import trading.lib.*
 
 import cats.~>
 import cats.effect.kernel.{ MonadCancelThrow, Resource }
 import cats.syntax.all.*
 import doobie.{ ConnectionIO, Transactor }
-import doobie.h2.*
 import doobie.implicits.*
 
 trait AuthorStore[F[_]]:

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/store/DB.scala b/modules/forecasts/src/main/scala/trading/forecasts/store/DB.scala
@@ -1,7 +1,6 @@
 package trading.forecasts.store
 
 import cats.effect.kernel.{ Async, Resource }
-import cats.syntax.all.*
 import doobie.ExecutionContexts
 import doobie.h2.H2Transactor
 import org.flywaydb.core.Flyway

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/store/DoobieTx.scala b/modules/forecasts/src/main/scala/trading/forecasts/store/DoobieTx.scala
@@ -6,7 +6,6 @@ import cats.~>
 import cats.arrow.FunctionK
 import cats.effect.kernel.{ Async, Resource }
 import cats.effect.kernel.Resource.ExitCase.*
-import cats.effect.syntax.all.*
 import cats.syntax.all.*
 import doobie.{ ConnectionIO, Transactor, WeakAsync }
 import doobie.free.connection.setAutoCommit

diff --git a/modules/forecasts/src/main/scala/trading/forecasts/store/ForecastStore.scala b/modules/forecasts/src/main/scala/trading/forecasts/store/ForecastStore.scala
@@ -2,13 +2,11 @@ package trading.forecasts.store
 
 import trading.domain.*
 import trading.events.ForecastEvent
-import trading.lib.*
 
 import cats.~>
 import cats.effect.kernel.{ MonadCancelThrow, Resource }
 import cats.syntax.all.*
 import doobie.{ ConnectionIO, Transactor }
-import doobie.h2.*
 import doobie.implicits.*
 
 trait ForecastStore[F[_]]:

diff --git a/modules/forecasts/src/test/scala/trading/forecasts/EngineSuite.scala b/modules/forecasts/src/test/scala/trading/forecasts/EngineSuite.scala
@@ -5,16 +5,13 @@ import java.util.UUID
 
 import trading.IsUUID
 import trading.commands.ForecastCommand
-import trading.domain.TradingStatus.*
 import trading.domain.*
 import trading.events.*
 import trading.forecasts.store.*
 import trading.lib.*
 import trading.lib.Consumer.{ Msg, MsgId }
 import trading.lib.Logger.NoOp.given
-import trading.state.*
 
-import cats.data.NonEmptyList
 import cats.effect.IO
 import cats.effect.kernel.{ Ref, Resource }
 import cats.syntax.all.*

diff --git a/modules/forecasts/src/test/scala/trading/forecasts/VotesHandlerSuite.scala b/modules/forecasts/src/test/scala/trading/forecasts/VotesHandlerSuite.scala
@@ -3,20 +3,16 @@ package trading.forecasts
 import java.time.Instant
 import java.util.UUID
 
-import trading.IsUUID
 import trading.domain.TradingStatus.*
 import trading.domain.*
 import trading.events.*
 import trading.forecasts.store.*
 import trading.lib.*
 import trading.lib.Consumer.{ Msg, MsgId }
 import trading.lib.Logger.NoOp.given
-import trading.state.*
 
-import cats.data.NonEmptyList
 import cats.effect.IO
 import cats.effect.kernel.{ Ref, Resource }
-import cats.effect.syntax.all.*
 import cats.syntax.all.*
 import weaver.{ Expectations, SimpleIOSuite }
 import weaver.scalacheck.Checkers