-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address ci deprecations #5076
Address ci deprecations #5076
Conversation
Hmm, some of the tests are failing, apparently due to this:
I am going to try a less aggressive update to ubuntu-22. Edit: I suspect this is due to ligo.skymap no longer supporting Python 3.9. If this is the case, we should be able to go all the way to ubuntu-24 once we drop the 3.9 tests. |
The Mac tests were also failing, but they are passing after clearing the CI cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues, and the CIs are passing
It seems the branch protection rules are somehow bound to the old versions of the tests, which will not run anymore. I guess I will temporarily remove those requirements, merge this, and then re-enable them with the new tests. |
* Update CI to Ubuntu 24.04 * Use Python 3.11 for distribution CI * Try ubuntu-22 for basic tests
I noticed a couple recent deprecations related to our CI tests. This should address them.
One is the version of Ubuntu: actions/runner-images#11101.
The other one is the Python version used to build the distribution workflow: