Improve decrypt_and_execute
#1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- (Better) ensure cleanup of /keys (might be skipped due to `set -e`) - Add usage message - Use a unique script filename - Decrypt "inplace" to avoid need to change directory - Exit with "correct" exit code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our current approach in case you might find it useful.
set -e)Noteworthy changes compare to original:
Especially the latter point might make it easier for users to reason about their scripts behavior as an encrypted script will behave (more) similar to the unencrypted one.
However the naive approach of a
cdto the original$PWDinside the "sudo"-part of the script triggered a failure when the PWD is in a user-readable directory with rootsquash enabled where root hence cannot enter.Hence the approach of decrypting the script inplace (at least it appears so) and switching back to the user context for running it.