Minerva oct eb857339 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an athena_sample_sizes() shim, to call Athena using the same call signature as bravo_sample_sizes()
Define get_athena_test_statistics() shim patterned after bravo.get_test_statistics() Still following earlier integration work based on ab525ad from 2020-05-05
Based on Arlo changes in the meantime.
Allow user to choose audit_math implementation at startup.
The default is now to use Athena, but the $ARLO_ALGORITHM environmental
variable can be used to select an algorithm at run time. E.g.:
ARLO_ALGORITHM=bravo ./run-dev.sh
N.B.: to avoid have to add too much other logic before
we decide on the best way to integrate this, we simply
conditionally replace bravo.bravo_sample_sizes with athena_sample_sizes:
if ALGORITHM == "athena":
bravo_sample_sizes = athena_sample_sizes
Also catch up with API updates in athena repo.
FIXME: bravo tests still broken Need to check the minerva test results.
Turned off logging-fstring-interpolation in .pylintrc. I think the possible tiny performance penalty is offset by the readability gains, as noted at pylint-dev/pylint#2354 (comment)
Note changes in Pipfile.lock - not sure if you want the rest of the packages to be updated, or to have specific version numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what is changed, including references to any relevant issues.]
Testing
[List all new test cases added to cover new functionality, including steps to reproduce expected results and contrasting with actual results.]
Progress
[List any work left to do or outstanding questions.]