Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use throw instead of assert where appropriate in MPI tools #183

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

EmilyBourne
Copy link
Member

Use throw instead of assert for errors that can be caused by the user in the mpi_parallelization folder.

@EmilyBourne EmilyBourne marked this pull request as ready for review March 13, 2025 15:53
@EmilyBourne EmilyBourne enabled auto-merge (squash) March 14, 2025 07:15
@github-actions github-actions bot marked this pull request as draft March 14, 2025 07:15
auto-merge was automatically disabled March 14, 2025 07:15

Pull request was converted to draft

Copy link

It seems like you haven't finished working on this PR so it has been put back into draft. Please remove the draft status when the PR can run tests without being interrupted.

@EmilyBourne EmilyBourne marked this pull request as ready for review March 14, 2025 07:15
@EmilyBourne EmilyBourne temporarily deployed to GitLab GPU trigger March 14, 2025 07:15 — with GitHub Actions Inactive
@github-actions github-actions bot marked this pull request as draft March 14, 2025 07:16
@EmilyBourne EmilyBourne marked this pull request as ready for review March 14, 2025 07:17
@gyselax gyselax deleted a comment from github-actions bot Mar 14, 2025
@gyselax gyselax deleted a comment from github-actions bot Mar 14, 2025
@EmilyBourne EmilyBourne enabled auto-merge (squash) March 14, 2025 07:17
@github-actions github-actions bot marked this pull request as draft March 14, 2025 07:37
auto-merge was automatically disabled March 14, 2025 07:37

Pull request was converted to draft

Copy link

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@EmilyBourne EmilyBourne marked this pull request as ready for review March 14, 2025 08:29
@EmilyBourne EmilyBourne merged commit 1ada4ba into main Mar 14, 2025
51 of 63 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_mpi_assertion branch March 14, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants