review comments

h00die · Dec 23, 2023 · e722429 · e722429
1 parent a5698f6
commit e722429
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/modules/exploits/linux/local/saltstack_salt_minion_deployer.rb b/modules/exploits/linux/local/saltstack_salt_minion_deployer.rb
@@ -108,11 +108,7 @@ def list_minions
   def check
     return CheckCode::Safe('salt-master does not seem to be installed, unable to find salt-master executable') if salt_master.nil?
 
-    if writable?(datastore['WritableDir'])
-      vprint_good("#{datastore['WritableDir']} is writable, and salt-master executable found")
-      return CheckCode::Vulnerable
-    end
-    CheckCode::Safe("#{datastore['WritableDir']} is not writable")
+    CheckCode::Vulnerable('salt-master executable found')
   end
 
   def exploit
@@ -141,6 +137,7 @@ def exploit
   end
 
   def on_new_session(_session)
+    super
     cli.core.use('stdapi') if !cli.ext.aliases.include?('stdapi')
 
     begin