Skip to content

Commit

Permalink
merging pull request fhessel#123
Browse files Browse the repository at this point in the history
  • Loading branch information
hakuamesan committed Sep 1, 2023
1 parent 4afc790 commit 1f7aec1
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 15 deletions.
29 changes: 15 additions & 14 deletions src/HTTPConnection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -290,23 +290,24 @@ void HTTPConnection::readLine(int lengthLimit) {
while(_bufferProcessed < _bufferUnusedIdx) {
char newChar = _receiveBuffer[_bufferProcessed];

if ( newChar == '\r') {
// Look ahead for \n (if not possible, wait for next round
if (_bufferProcessed+1 < _bufferUnusedIdx) {
if (_receiveBuffer[_bufferProcessed+1] == '\n') {
_bufferProcessed += 2;
_parserLine.parsingFinished = true;
return;
} else {
// Line has not been terminated by \r\n
HTTPS_LOGW("Line without \\r\\n (got only \\r). FID=%d", _socket);
raiseError(400, "Bad Request");
return;
}
_bufferProcessed++;
if ( partialTerminationParsed ){
partialTerminationParsed = false;
if (newChar == '\n') {
_parserLine.parsingFinished = true;
} else {
// Line has not been terminated by \r\n
HTTPS_LOGW("Line without \\r\\n (got only \\r). FID=%d", _socket);
raiseError(400, "Bad Request");
}
return;
}

if ( newChar == '\r'){
partialTerminationParsed = true;
} else {
_parserLine.text += newChar;
_bufferProcessed += 1;

}

// Check that the max request string size is not exceeded
Expand Down
3 changes: 2 additions & 1 deletion src/HTTPConnection.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ class HTTPConnection : private ConnectionContext {
int _bufferProcessed;
// The index on the receive_buffer that is the first one which is empty at the end.
int _bufferUnusedIdx;

bool partialTerminationParsed = false;

// Socket address, length etc for the connection
struct sockaddr _sockAddr;
socklen_t _addrLen;
Expand Down

0 comments on commit 1f7aec1

Please sign in to comment.