feat: Show "Sending..." state immediately after clicking the send but… #7065
Conversation
…ton, start countdown only after successful request
f2c-ci-robot
bot
added
the
kind/feature
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2c-ci-robot
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
| sendRequest() | ||
| .then(() => { | ||
| startCountdown(); | ||
| Toast.success(i18nResources.sendVerificationCodeSuccess); | ||
| }) | ||
| .catch((e) => { | ||
| button.disabled = false; | ||
| button.textContent = "Send"; |
There was a problem hiding this comment.
完善 i18n，或者在首次更改 button.textContent 之前缓存一下按钮的原始文字（推荐），比如：
function sendVerificationCode(button, sendRequest) {
let timer;
const countdown = 60;
let originalButtonText = button.textContent;
button.addEventListener("click", () => {
button.disabled = true;
button.textContent = "Sending...";
sendRequest()
.then(() => {
startCountdown();
Toast.success(i18nResources.sendVerificationCodeSuccess);
})
.catch((e) => {
button.disabled = false;
button.textContent = originalButtonText;
...There was a problem hiding this comment.
下面的 startCountdown 方法中设置 button.textContent 似乎也没有 i18n，建议帮忙修改下。
| @@ -93,13 +93,15 @@ function sendVerificationCode(button, sendRequest) { | |||
|
|
|||
| button.addEventListener("click", () => { | |||
| button.disabled = true; | |||
| button.textContent = "Sending..."; | |||
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR modifies the behavior of the "Send" button for sending verification codes. Now, when the button is clicked, it immediately shows a "Sending..." state, improving user experience by providing instant feedback. After a successful request, a countdown is displayed. This makes the process clearer for users and reduces confusion during waiting time.
Which issue(s) this PR fixes:
Fixes #7064
Special notes for your reviewer:
Please review the implementation for consistent UI behavior and ensure no race conditions occur if the button is clicked multiple times quickly.
Does this PR introduce a user-facing change?
Improved user experience for sending verification codes: the button now immediately shows "