Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make displayName field optional during registration #7067

Closed
wants to merge 1 commit into from

Conversation

zly199
Copy link
Contributor

@zly199 zly199 commented Nov 22, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds the feature to make the name field optional during registration. This improves the user experience by allowing flexibility in the registration process.

Which issue(s) this PR fixes:

Fixes #7066

Special notes for your reviewer:
Please focus on the validation logic for optional fields and ensure it aligns with existing registration requirements.

Does this PR introduce a user-facing change?

release
复制代码
The name field in the registration form is now optional, enhancing flexibility during user si

@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2024
Copy link

f2c-ci-robot bot commented Nov 22, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby November 22, 2024 15:36
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 22, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

f2c-ci-robot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilgg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zly199 zly199 changed the title feat: make name field optional during registration feat: make displayName field optional during registration Nov 22, 2024
@zly199 zly199 closed this by deleting the head repository Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户注册时, 显示名称可选填
2 participants