Skip to content

Commit

Permalink
build: remove nightly with rawspeed because github workers llvm is to…
Browse files Browse the repository at this point in the history 
…o old
  • Loading branch information
@hanatos
hanatos committed Mar 7, 2024
1 parent efb47c1 commit 19ab7e2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:

jobs:
AppImage:
if: github.repository == 'hanatos/vkdt'
if: github.repository == 'hanatos/vkdt' && false
name: nightly vkdt appimage
runs-on: ubuntu-latest
strategy:
Expand Down

4 comments on commit 19ab7e2

@LebedevRI
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanatos continuing from darktable-org/rawspeed#709 (comment)

Two notes:

  1. It's possibly unoptimal to directly use the runs-on: ubuntu-latest, instead you may want to use https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container (see how it's done in rawspeed repo)
  2. Regardless of the previous point, there's always https://apt.llvm.org/ to get the newer compiler versions...

@hanatos
Copy link
Owner Author

@hanatos hanatos commented on 19ab7e2 May 20, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LebedevRI
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. i went the apt.llvm.org route to bring it back now. it's ridiculous not to have rawspeed enabled packages.

Well, i didn't know that this commit happened :]

@hanatos
Copy link
Owner Author

@hanatos hanatos commented on 19ab7e2 May 20, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.