remove fixme

hapifhir · Feb 12, 2025 · 07096e9 · 07096e9
1 parent 1da23c8
commit 07096e9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/hapi-fhir-base/src/main/java/ca/uhn/fhir/interceptor/model/RequestPartitionId.java b/hapi-fhir-base/src/main/java/ca/uhn/fhir/interceptor/model/RequestPartitionId.java
@@ -333,13 +333,13 @@ public static RequestPartitionId allPartitions() {
 	}
 
 	@Nonnull
-//	TODO GGG: This is a now-bad usage and we should remove it. we cannot assume null means default.
+	//	TODO GGG: This is a now-bad usage and we should remove it. we cannot assume null means default.
 	public static RequestPartitionId defaultPartition() {
 		return fromPartitionIds(Collections.singletonList(null));
 	}
 
 	@Nonnull
-//	TODO GGG: This is a now-bad usage and we should remove it. we cannot assume null means default.
+	//	TODO GGG: This is a now-bad usage and we should remove it. we cannot assume null means default.
 	public static RequestPartitionId defaultPartition(@Nullable LocalDate thePartitionDate) {
 		return fromPartitionIds(Collections.singletonList(null), thePartitionDate);
 	}

diff --git a/...tion/src/main/java/ca/uhn/fhir/jpa/subscription/model/config/SubscriptionModelConfig.java b/...tion/src/main/java/ca/uhn/fhir/jpa/subscription/model/config/SubscriptionModelConfig.java
@@ -32,7 +32,6 @@ public class SubscriptionModelConfig {
 	@Bean
 	public SubscriptionCanonicalizer subscriptionCanonicalizer(
 			FhirContext theFhirContext, SubscriptionSettings theSubscriptionSettings) {
-		//FIXME GGG
 		return new SubscriptionCanonicalizer(theFhirContext, theSubscriptionSettings);
 	}
 

diff --git a/.../src/main/java/ca/uhn/fhir/jpa/subscription/match/registry/SubscriptionCanonicalizer.java b/.../src/main/java/ca/uhn/fhir/jpa/subscription/match/registry/SubscriptionCanonicalizer.java
@@ -74,14 +74,14 @@ public class SubscriptionCanonicalizer {
 
 	private IRequestPartitionHelperSvc myHelperSvc;
 
-
 	@Autowired
 	public SubscriptionCanonicalizer(FhirContext theFhirContext, SubscriptionSettings theSubscriptionSettings) {
 		myFhirContext = theFhirContext;
 		mySubscriptionSettings = theSubscriptionSettings;
 	}
-	//TODO GGG: Eventually, we will unify autowiring styles. It is this way now as this is the least destrctive method
-	//to accomplish a minimal MR. I recommend moving all dependencies to setter autowiring, but that is for another day.
+	// TODO GGG: Eventually, we will unify autowiring styles. It is this way now as this is the least destrctive method
+	// to accomplish a minimal MR. I recommend moving all dependencies to setter autowiring, but that is for another
+	// day.
 	@Autowired
 	public void setPartitionHelperSvc(IRequestPartitionHelperSvc thePartitionHelperSvc) {
 		myHelperSvc = thePartitionHelperSvc;
@@ -797,7 +797,9 @@ private boolean handleCrossPartition(IBaseResource theSubscription) {
 		boolean isSubscriptionCreatedOnDefaultPartition = false;
 
 		if (nonNull(requestPartitionId)) {
-			isSubscriptionCreatedOnDefaultPartition = myHelperSvc == null ? requestPartitionId.isDefaultPartition() : myHelperSvc.isDefaultPartition(requestPartitionId);
+			isSubscriptionCreatedOnDefaultPartition = myHelperSvc == null
+					? requestPartitionId.isDefaultPartition()
+					: myHelperSvc.isDefaultPartition(requestPartitionId);
 		}
 
 		boolean isSubscriptionDefinededAsCrossPartitionSubscription =