Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
leif stawnyczy committed Feb 7, 2025
1 parent cb231ec commit e630473
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ void testPartitionBySizeAndPartitionId_ReuseIfSmallEnoughAndAllSamePartition() {
@ParameterizedTest
@ValueSource(booleans = { true, false })
@SuppressWarnings("unchecked")
public void loadResourcesByPid_containsNoNullElements(boolean theUseElastisearch) {
public void loadResourcesByPid_containsNoNullElements(boolean theUseElasticSearch) {
// setup
List<JpaPid> pids = new ArrayList<>();
List<JpaPid> includedPids = new ArrayList<>();
Expand All @@ -132,7 +132,7 @@ public void loadResourcesByPid_containsNoNullElements(boolean theUseElastisearch
Patient patient = new Patient();
patient.setId("Patient/1");

if (theUseElastisearch) {
if (theUseElasticSearch) {
mySearchBuilder.setFullTextSearch(myFulltextSearchSvc);

myStorageSettings.setStoreResourceInHSearchIndex(true);
Expand All @@ -142,7 +142,7 @@ public void loadResourcesByPid_containsNoNullElements(boolean theUseElastisearch

// when
// (these are just for output values)
if (!theUseElastisearch) {
if (!theUseElasticSearch) {
ResourceHistoryTable ht = new ResourceHistoryTable();
ht.setResourceId(1L);
ht.setResourceType("Patient");
Expand Down Expand Up @@ -170,7 +170,7 @@ public void loadResourcesByPid_containsNoNullElements(boolean theUseElastisearch

// validating the returns for completion's sake
assertEquals(1, resources.size());
if (theUseElastisearch) {
if (theUseElasticSearch) {
// if using elastisearch, we want to know the getResources was invoked
// with the pid list we sent in
ArgumentCaptor<Collection<Long>> pidCapture = ArgumentCaptor.forClass(Collection.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,9 @@ public void before() throws Exception {

@ParameterizedTest
@ValueSource(booleans = { true, false })
public void syncDatabaseToCache_elasticSearchOrJPA_shouldNotFail(boolean theUseElastisearch) throws Exception {
public void syncDatabaseToCache_elasticSearchOrJPA_shouldNotFail(boolean theUseElasticSearch) throws Exception {
// setup
if (theUseElastisearch) {
if (theUseElasticSearch) {
myStorageSettings.setStoreResourceInHSearchIndex(true);
myStorageSettings.setHibernateSearchIndexSearchParams(true);
}
Expand Down

0 comments on commit e630473

Please sign in to comment.