Refactor createAssetPackage to use happo.io's deterministicArchive #68
+70
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how we create archives elsewhere, so we might as well build on top of it. One improvement with this method is it enables zlib compression at level 6, which in my tests seems to reduce the size of asset packages by about 14%. That is one reach the package hash in the tests changed.
lencioni
commented
Feb 18, 2025
| // Get all of the archive items in parallel first. Then add them to the | ||
| // archive serially afterwards to ensure that packages are created | ||
| // deterministically. | ||
| await Promise.all( |
There was a problem hiding this comment.
We should probably use p-all here, to ensure the concurrency isn't too high.
lencioni
commented
Feb 18, 2025
|
|
||
| seenUrls.add(name); | ||
|
|
||
| if (/\.happo-tmp\/_inlined/.test(name)) { |
There was a problem hiding this comment.
This should probably use string.includes instead of a regex test.
lencioni
commented
Feb 18, 2025
| @@ -45,13 +45,18 @@ describe('createAssetPackage', () => { | |||
| }, | |||
| ]); | |||
|
|
|||
| assert.equal(pkg.hash, '898862aad00d429b73f57256332a6ee1'); | |||
| assert.equal(pkg.hash, '8cdd63709442c4f37034425715630055'); | |||
There was a problem hiding this comment.
The hash is different because the determinsticArchive function uses zlib compression level of 6 (archiver's default seems to be 1, which is not great compression). I think the entries in the zip are also ordered differently now, which would also change the hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how we create archives elsewhere, so we might as well build on top of it.
One improvement with this method is it enables zlib compression at level 6, which in my tests seems to reduce the size of asset packages by about 14%. That is one reach the package hash in the tests changed.