Refactor controller to use uploadAssets from happo.io package #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been making some improvments in the core happo.io package to how assets are uploaded. To ensure that happo-e2e consumers benefit from these improvments, I am refactoring the controller to use the uploadAssets function from that package. This also gives us a little less code to maintain here, which is nice.
lencioni
commented
Feb 18, 2025
Comment on lines
-137
to
-141
| if (this.happoDebug) { | ||
| console.log( | ||
| `[HAPPO] Reusing existing assets at ${assetsDataRes.path} (previously uploaded on ${assetsDataRes.uploadedAt})`, | ||
| ); | ||
| } |
There was a problem hiding this comment.
One downside with this change is that we won't be dropping these logs as nicely as we currently do when this.happoDebug is truthy.
We should maybe look at how this works across packages and attempt to unify it a bit so it would just work.
lencioni
commented
Feb 18, 2025
| apiKey: this.happoConfig.apiKey, | ||
| apiSecret: this.happoConfig.apiSecret, | ||
| logger: console, | ||
| project: this.happoConfig.project, |
There was a problem hiding this comment.
project is currently only used for some logging in uploadAssets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been making some improvments in the core happo.io package to how assets are uploaded. To ensure that happo-e2e consumers benefit from these improvments, I am refactoring the controller to use the uploadAssets function from that package. This also gives us a little less code to maintain here, which is nice.