Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF4 reader updates #1892

Merged
merged 7 commits into from
Nov 15, 2024
Merged

MF4 reader updates #1892

merged 7 commits into from
Nov 15, 2024

Conversation

cssedev
Copy link
Contributor

@cssedev cssedev commented Nov 8, 2024

Continuation of PR #1884, which got lost in the rebase

@cssedev
Copy link
Contributor Author

cssedev commented Nov 11, 2024

Should the commits be squished once all checks have passed?

@hardbyte
Copy link
Owner

Should the commits be squished once all checks have passed?

Yes usually we squash and rebase once everything in the CI is passing.

@cssedev
Copy link
Contributor Author

cssedev commented Nov 12, 2024

The failing test from the last run does not seem to originate from the changes in this PR. Is there a way to re-run a single test, or do you have any idea of how to resolve the remaining issue?

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hardbyte hardbyte merged commit 805f3fb into hardbyte:main Nov 15, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants