Fix is_rx
for receive_own_messages
for Kvaser
#1908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and changes
Most other interfaces set
is_rx
toFalse
if a transmitted message is received whenreceive_own_messages
is enabled.This previously wasn't the case for Kvaser.
Enabling the
LOCAL_TXACK
flag allows us to determine this.Testing
This can be manually tested with a simple script:
Before this change, transmitted messages will be printed as "Rx", after as "Tx".
Do let me know if there's some obvious way to check this in automated tests.