Add Stream Health Monitoring and Improve Request Handling #4857
+110
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
monitorStreamHealthfunction to enhance the request manager's ability to detect and handle situations where no active streams are available. It acts as a watchdog by continuously checking the stream list and, if no connections remain for a predefined threshold, it cancels all pending requests to prevent overload and unnecessary waiting. This change helps ensure that requests do not remain indefinitely in the queue when no valid peers are reachable.Additionally, a test has been added to verify that when all streams are removed, pending requests are correctly canceled with an appropriate error.