FFM-12087 New configuration options + close related bug fixes #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source (streaming) code
FFM-12087 Add maxRequestConfig FFM-12087 Add maxRequestConfig FFM-12087 Add maxRequestConfig
FFM-12087 Apply timeout to metrics flush request
erdirowlands
force-pushed
the
FFM-12087
branch
from
c049617 to
1eb01e5
Compare
erdirowlands
changed the title
erdirowlands
force-pushed
the
FFM-12087
branch
from
7ad15be to
ae447a2
Compare
akiraqb
approved these changes
Oct 4, 2024
| @@ -48,7 +60,7 @@ public static void main(String[] args) { | |||
| TimeUnit.SECONDS); | |||
|
|
|||
| // SDK will exit after 15 minutes, this gives the example time to stream events | |||
There was a problem hiding this comment.
maybe worth updating the comment in line?
Thanks! Addressed your concern on slack but will put it here as well: If streaming is enabled, then 99.9 percent of cases it should try to reconnect forever with exponential back off. I've only ever encountered one edge case in 2 years where a customer wants to limit stream retries for a client session, and that was on the browser (JS SDK) so we added a stream retry config there |
FFM-12087 Bump version
erdirowlands
force-pushed
the
FFM-12087
branch
from
ae447a2 to
71bee73
Compare
erdirowlands
force-pushed
the
FFM-12087
branch
from
92d3f80 to
017b74c
Compare
erdirowlands
force-pushed
the
FFM-12087
branch
from
017b74c to
ffb0065
Compare
erdirowlands
force-pushed
the
FFM-12087
branch
from
a09f56a to
183dce2
Compare
erdirowlands
force-pushed
the
FFM-12087
branch
from
183dce2 to
eac0984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds two new features, and fixes some bugs around closing the SDK.
New Features
Retries
Adds new
maxRequestRetryoption, defaulting to10, which controls the number of retries made for requests toauth/polling/metrics/fetch flagandfetch grouprequestsChanges the stream reconnect limit from
5attempts to no limit. This was a bug, and to align with our SDKs the stream should always attempt to reconnect (on retryable errors)Exponential backoff capped at 1 minute max delay.
Flush metrics when SDK is closed
flushAnalyticsOnClose, defaulting todisabled, which will post analytics when the SDK is closed. The default timeout for this request is30000ms, before which the SDK will not be fully closed and network resources used by the request will remain open.flushAnalyticsOnCloseTimeout, defaulting to30000ms, which can help if the user prefers a shorter or longer timeout before all SDK resources are closed.Bug fixes
.executorService().shutdown();Testing
Issues
#201
#202