Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance textarea #89

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

iitzIrFan
Copy link
Contributor

#53 Enhance TextArea component accessibility

  • Proper labeling with the textarea element.
  • Added correct aria attributes.
  • To prevent conflicts between multiple text input components I had added unique id's.
  • Other required changes as per the report.

This was done to Enhance the accessibility of TextArea component as Lighthouse tool & hooping it would be merged in main branch of the project.

@harshmangalam harshmangalam changed the base branch from main to dev October 17, 2024 21:42
@harshmangalam harshmangalam merged commit 3113144 into harshmangalam:dev Oct 17, 2024
1 check passed
@harshmangalam
Copy link
Owner

Thanks

@iitzIrFan
Copy link
Contributor Author

Your welcome.

@harshmangalam
Copy link
Owner

Hi @iitzIrFan ,

Thank you so much for contributing to qwik-x during Hacktoberfest! Your efforts are truly appreciated, and we’d love to give you kudos and a shout-out for your amazing work.

If you're comfortable, please feel free to share your social media handles like linkedin, twitter,etc... so we can tag you in our appreciation posts and spread the word about your contributions!

Looking forward to seeing you in the community. Thanks again for being awesome!

Best,
Harsh Mangalam
Maintainer qwik-x

@iitzIrFan
Copy link
Contributor Author

iitzIrFan commented Oct 20, 2024

@harshmangalam

Thanks for the appreciation! It was great contributing to qwik-x during Hacktoberfest. Here’s my LinkedIn handle :- www.linkedin.com/in/irfan-shaikh-8b5b94259. I’d be grateful if you could recommend me on LinkedIn for my work on the project.

Looking forward to staying connected!

Best,
Irfan Shaikh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants