Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Add volume_folder to export json #2208

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jcushman
Copy link
Contributor

@jcushman jcushman commented Mar 6, 2024

Add "volume_folder" to exported metadata for volumes, so we can link correctly when there are multiple volumes with the same volume_number.

I also added the missing line reporter = Reporter.objects.filter(short_name_slug=reporter_dir.name).exclude(start_year=None).get(), which I used for the export and had sitting around locally but failed to include in a previous PR.

@jcushman jcushman requested a review from a team as a code owner March 6, 2024 01:29
@jcushman jcushman requested review from teovin and removed request for a team March 6, 2024 01:29
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (b9abdf8) to head (90768a9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2208      +/-   ##
===========================================
+ Coverage    63.57%   63.58%   +0.01%     
===========================================
  Files          107      107              
  Lines        11859    11863       +4     
===========================================
+ Hits          7539     7543       +4     
  Misses        4320     4320              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bensteinberg bensteinberg merged commit f8db93b into harvard-lil:develop Mar 6, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants